Additional bold italic detection #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l bolditalic font detection
|
thanks |
modesty
added a commit
that referenced
this pull request
Nov 10, 2023
Additional bold italic detection
|
@modesty @todorowww VGDDOL+NimbusRomNo9L-Regu |
|
And is it a typo here? Should const _boldSubNames = ['bd', 'bold', 'demi', 'black']; |
No, not a typo, it's actually demi, meaning half-size. You can add all the cases you find that would improve detection, however, I haven't used this package in quite some time, so I can't really be of too much assistance. |
|
Hmmmmm, got it, thanks for the reply, I'll submit a pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have updated the code to extend existing fix for issue #42 and added another detection - bolditalic fonts. So, when we don't have bold or italic set, and fonr identifies itself by "boldobl" in it's name, set bold and italic properties of the text.
It is possible that this doesn't cover all possible situations. This fix is made from my own situation where existing bold/italic detection has failed.